Code Refactoring

Activity 1.38.1.

There is a copy of the following code block in an interactive mode that you can modify and compile. Your task is to improve the code’s style as an expert would view it, while ensuring its behavior remains unchanged. You may run your refactored code to verify that it still passes all test cases.

🔗

public class FileProcess {
	public static boolean canProcessFile(int fileSize, boolean hasPermission) {
		if (!hasPermission) {
			   return false; 
		}
		if (fileSize >= 1024) {
			   return false; 
		}
		return true;
	}
}

public class FileProcess {
	public static boolean canProcessFile(int fileSize, boolean hasPermission) {
		if (!hasPermission) {
			   return false; 
		}
		if (fileSize >= 1024) {
			   return false; 
		}
		return true;
	}
}
====
           	import static org.junit.Assert.*;
import org.junit.Test;
import java.io.*;
import org.junit.Before;
import org.junit.After;
import java.io.ByteArrayOutputStream;
import java.io.PrintStream;

public class RunestoneTests extends CodeTestHelper {

public RunestoneTests() {
		super("FileProcess");
	}

// Test for permission be false
	@Test
	public void testPermission() throws IOException {
		Object[] args = {1010,false};  // Arguments for the method
		String output = getMethodOutput("canProcessFile", args);
		String expect = Boolean.toString(false);  // Convert expected boolean to String
		
		boolean passed = getResults(expect, output, "canProcessFile(1010,false)");  
		assertTrue(passed);
	}

// Test for true 
	@Test
	public void testCanProcess() throws IOException {
		Object[] args = {1032, true};  // Arguments for the method
		String output = getMethodOutput("canProcessFile", args);
		String expect = Boolean.toString(false);  // Convert expected boolean to String
		
		boolean passed = getResults(expect, output, "canProcessFile(1032,false)");  
		assertTrue(passed);
	}

// Test for high volume file
	@Test
	public void testLargeFile() throws IOException {
		Object[] args = {1040, true};  // Arguments for the method
		String output = getMethodOutput("canProcessFile", args);
		String expect = Boolean.toString(false);  // Convert expected boolean to String
		
		boolean passed = getResults(expect, output, "canProcessFile(1040, true)");  
		assertTrue(passed);
	}

}

🔗

Activity 1.38.2.

Which of the following code blocks is the most similar to your final refactored code for the previous question?

🔗

public class FileProcess {
	public static boolean canProcessFile(int fileSize, boolean hasPermission) {
		if (!hasPermission || fileSize >= 1024) {
			return false; 
		}
		return true;
	}
}

This code can further be improved!

public class FileProcess {
	public static boolean canProcessFile(int fileSize, boolean hasPermission) {
		if (hasPermission && fileSize < 1024) {
			return true; 
		}
		return false;
	}
}

This code can further be improved!

public class FileProcess {
	public static boolean canProcessFile(int fileSize, boolean hasPermission) {
		return hasPermission && fileSize < 1024;
	}
}

You refactored correctly!

🔗

Practice Code Structure

Section 1.38 Code Refactoring

Activity 1.38.1.

Activity 1.38.2.